From 2a209d43afaab9b253f775ee3caccc9608562c7e Mon Sep 17 00:00:00 2001
From: Archer <545436317@qq.com>
Date: Mon, 3 Feb 2025 14:21:54 +0800
Subject: [PATCH] fix: reasoning response (#3684)

* perf: supplement assistant empty response

* check array

* fix: reasoning response

* fix: reasoning response
---
 packages/global/core/app/type.d.ts            |  1 +
 packages/global/core/app/utils.ts             |  3 +-
 .../core/workflow/dispatch/chat/oneapi.ts     |  2 +-
 .../service/core/workflow/dispatch/index.ts   | 31 ++++++++-------
 .../core/workflow/dispatch/tools/http468.ts   |  1 -
 .../core/chat/ChatContainer/ChatBox/index.tsx | 38 +++++++++----------
 .../core/chat/components/AIResponseBox.tsx    | 17 +++++++--
 .../app/detail/SimpleApp/EditForm.tsx         | 14 +++++--
 projects/app/src/web/core/app/utils.ts        |  7 ++++
 9 files changed, 71 insertions(+), 43 deletions(-)

diff --git a/packages/global/core/app/type.d.ts b/packages/global/core/app/type.d.ts
index ec30e4b51..1008344d2 100644
--- a/packages/global/core/app/type.d.ts
+++ b/packages/global/core/app/type.d.ts
@@ -80,6 +80,7 @@ export type AppSimpleEditFormType = {
     maxToken?: number;
     isResponseAnswerText: boolean;
     maxHistories: number;
+    [NodeInputKeyEnum.aiChatReasoning]?: boolean;
   };
   dataset: {
     datasets: SelectedDatasetType;
diff --git a/packages/global/core/app/utils.ts b/packages/global/core/app/utils.ts
index 1c793cfea..708964b38 100644
--- a/packages/global/core/app/utils.ts
+++ b/packages/global/core/app/utils.ts
@@ -16,7 +16,8 @@ export const getDefaultAppForm = (): AppSimpleEditFormType => {
       temperature: 0,
       isResponseAnswerText: true,
       maxHistories: 6,
-      maxToken: 4000
+      maxToken: 4000,
+      aiChatReasoning: true
     },
     dataset: {
       datasets: [],
diff --git a/packages/service/core/workflow/dispatch/chat/oneapi.ts b/packages/service/core/workflow/dispatch/chat/oneapi.ts
index 0d3482b68..4b8cc865c 100644
--- a/packages/service/core/workflow/dispatch/chat/oneapi.ts
+++ b/packages/service/core/workflow/dispatch/chat/oneapi.ts
@@ -88,7 +88,7 @@ export const dispatchChatCompletion = async (props: ChatProps): Promise<ChatResp
       quoteTemplate,
       quotePrompt,
       aiChatVision,
-      aiChatReasoning,
+      aiChatReasoning = true,
       fileUrlList: fileLinks, // node quote file links
       stringQuoteText //abandon
     }
diff --git a/packages/service/core/workflow/dispatch/index.ts b/packages/service/core/workflow/dispatch/index.ts
index 3846f85ce..b7cbf8479 100644
--- a/packages/service/core/workflow/dispatch/index.ts
+++ b/packages/service/core/workflow/dispatch/index.ts
@@ -241,25 +241,28 @@ export async function dispatchWorkFlow(data: Props): Promise<DispatchFlowRespons
     // Histories store
     if (assistantResponses) {
       chatAssistantResponse = chatAssistantResponse.concat(assistantResponses);
-    } else if (answerText) {
-      // save assistant text response
-      const isResponseAnswerText =
-        inputs.find((item) => item.key === NodeInputKeyEnum.aiChatIsResponseText)?.value ?? true;
-      if (isResponseAnswerText) {
+    } else {
+      if (reasoningText) {
         chatAssistantResponse.push({
-          type: ChatItemValueTypeEnum.text,
-          text: {
-            content: answerText
+          type: ChatItemValueTypeEnum.reasoning,
+          reasoning: {
+            content: reasoningText
           }
         });
       }
-    } else if (reasoningText) {
-      chatAssistantResponse.push({
-        type: ChatItemValueTypeEnum.reasoning,
-        reasoning: {
-          content: reasoningText
+      if (answerText) {
+        // save assistant text response
+        const isResponseAnswerText =
+          inputs.find((item) => item.key === NodeInputKeyEnum.aiChatIsResponseText)?.value ?? true;
+        if (isResponseAnswerText) {
+          chatAssistantResponse.push({
+            type: ChatItemValueTypeEnum.text,
+            text: {
+              content: answerText
+            }
+          });
         }
-      });
+      }
     }
 
     if (rewriteHistories) {
diff --git a/packages/service/core/workflow/dispatch/tools/http468.ts b/packages/service/core/workflow/dispatch/tools/http468.ts
index af8b6982f..5ea110b88 100644
--- a/packages/service/core/workflow/dispatch/tools/http468.ts
+++ b/packages/service/core/workflow/dispatch/tools/http468.ts
@@ -244,7 +244,6 @@ export const dispatchHttp468Request = async (props: HttpRequestProps): Promise<H
       if (!httpJsonBody) return {};
       if (httpContentType === ContentTypes.json) {
         httpJsonBody = replaceJsonBodyString(httpJsonBody);
-        console.log(httpJsonBody);
         return json5.parse(httpJsonBody);
       }
 
diff --git a/projects/app/src/components/core/chat/ChatContainer/ChatBox/index.tsx b/projects/app/src/components/core/chat/ChatContainer/ChatBox/index.tsx
index 56cb41e7f..d86e706b6 100644
--- a/projects/app/src/components/core/chat/ChatContainer/ChatBox/index.tsx
+++ b/projects/app/src/components/core/chat/ChatContainer/ChatBox/index.tsx
@@ -226,6 +226,25 @@ const ChatBox = ({
               status,
               moduleName: name
             };
+          } else if (event === SseResponseEventEnum.answer && reasoningText) {
+            if (lastValue.type === ChatItemValueTypeEnum.reasoning && lastValue.reasoning) {
+              lastValue.reasoning.content += reasoningText;
+              return {
+                ...item,
+                value: item.value.slice(0, -1).concat(lastValue)
+              };
+            } else {
+              const val: AIChatItemValueItemType = {
+                type: ChatItemValueTypeEnum.reasoning,
+                reasoning: {
+                  content: reasoningText
+                }
+              };
+              return {
+                ...item,
+                value: item.value.concat(val)
+              };
+            }
           } else if (
             (event === SseResponseEventEnum.answer || event === SseResponseEventEnum.fastAnswer) &&
             text
@@ -248,25 +267,6 @@ const ChatBox = ({
                 value: item.value.slice(0, -1).concat(lastValue)
               };
             }
-          } else if (event === SseResponseEventEnum.answer && reasoningText) {
-            if (lastValue.type === ChatItemValueTypeEnum.reasoning && lastValue.reasoning) {
-              lastValue.reasoning.content += reasoningText;
-              return {
-                ...item,
-                value: item.value.slice(0, -1).concat(lastValue)
-              };
-            } else {
-              const val: AIChatItemValueItemType = {
-                type: ChatItemValueTypeEnum.reasoning,
-                reasoning: {
-                  content: reasoningText
-                }
-              };
-              return {
-                ...item,
-                value: item.value.concat(val)
-              };
-            }
           } else if (event === SseResponseEventEnum.toolCall && tool) {
             const val: AIChatItemValueItemType = {
               type: ChatItemValueTypeEnum.tool,
diff --git a/projects/app/src/components/core/chat/components/AIResponseBox.tsx b/projects/app/src/components/core/chat/components/AIResponseBox.tsx
index 552171a71..3eb8a2056 100644
--- a/projects/app/src/components/core/chat/components/AIResponseBox.tsx
+++ b/projects/app/src/components/core/chat/components/AIResponseBox.tsx
@@ -142,15 +142,18 @@ ${toolResponse}`}
 );
 const RenderResoningContent = React.memo(function RenderResoningContent({
   content,
-  showAnimation
+  isChatting,
+  isLastResponseValue
 }: {
   content: string;
-  showAnimation: boolean;
+  isChatting: boolean;
+  isLastResponseValue: boolean;
 }) {
   const { t } = useTranslation();
+  const showAnimation = isChatting && isLastResponseValue;
 
   return (
-    <Accordion allowToggle defaultIndex={0}>
+    <Accordion allowToggle defaultIndex={isLastResponseValue ? 0 : undefined}>
       <AccordionItem borderTop={'none'} borderBottom={'none'}>
         <AccordionButton
           w={'auto'}
@@ -341,7 +344,13 @@ const AIResponseBox = ({ value, isLastResponseValue, isChatting }: props) => {
       <RenderText showAnimation={isChatting && isLastResponseValue} text={value.text.content} />
     );
   if (value.type === ChatItemValueTypeEnum.reasoning && value.reasoning)
-    return <RenderResoningContent showAnimation={isChatting} content={value.reasoning.content} />;
+    return (
+      <RenderResoningContent
+        isChatting={isChatting}
+        isLastResponseValue={isLastResponseValue}
+        content={value.reasoning.content}
+      />
+    );
   if (value.type === ChatItemValueTypeEnum.tool && value.tools)
     return <RenderTool showAnimation={isChatting} tools={value.tools} />;
   if (value.type === ChatItemValueTypeEnum.interactive && value.interactive) {
diff --git a/projects/app/src/pageComponents/app/detail/SimpleApp/EditForm.tsx b/projects/app/src/pageComponents/app/detail/SimpleApp/EditForm.tsx
index 44d407692..899e4bce1 100644
--- a/projects/app/src/pageComponents/app/detail/SimpleApp/EditForm.tsx
+++ b/projects/app/src/pageComponents/app/detail/SimpleApp/EditForm.tsx
@@ -138,9 +138,16 @@ const EditForm = ({
                   model: appForm.aiSettings.model,
                   temperature: appForm.aiSettings.temperature,
                   maxToken: appForm.aiSettings.maxToken,
-                  maxHistories: appForm.aiSettings.maxHistories
+                  maxHistories: appForm.aiSettings.maxHistories,
+                  aiChatReasoning: appForm.aiSettings.aiChatReasoning ?? true
                 }}
-                onChange={({ model, temperature, maxToken, maxHistories }: SettingAIDataType) => {
+                onChange={({
+                  model,
+                  temperature,
+                  maxToken,
+                  maxHistories,
+                  aiChatReasoning = false
+                }) => {
                   setAppForm((state) => ({
                     ...state,
                     aiSettings: {
@@ -148,7 +155,8 @@ const EditForm = ({
                       model,
                       temperature,
                       maxToken,
-                      maxHistories: maxHistories ?? 6
+                      maxHistories: maxHistories ?? 6,
+                      aiChatReasoning
                     }
                   }));
                 }}
diff --git a/projects/app/src/web/core/app/utils.ts b/projects/app/src/web/core/app/utils.ts
index 5a8546a58..4262a4c2a 100644
--- a/projects/app/src/web/core/app/utils.ts
+++ b/projects/app/src/web/core/app/utils.ts
@@ -190,6 +190,13 @@ export function form2AppWorkflow(
           label: '',
           valueType: WorkflowIOValueTypeEnum.boolean,
           value: true
+        },
+        {
+          key: NodeInputKeyEnum.aiChatReasoning,
+          renderTypeList: [FlowNodeInputTypeEnum.hidden],
+          label: '',
+          valueType: WorkflowIOValueTypeEnum.boolean,
+          value: formData.aiSettings.aiChatReasoning
         }
       ],
       outputs: AiChatModule.outputs